Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepin: kbuild: Reapply support for CONFIG_CC_OPTIMIZE_FOR_PERFORMANC… #414

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Avenger-285714
Copy link
Collaborator

…E_O3

  1. Revert (a6036a4 "kbuild: drop support for CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE_O3")
  2. Mark -O3 as experimental, as it might cause unwanted regressions for users.
  3. Allow all architectures to use the experimental -O3 optimization option. Previously, only ARC was allowed to use this option.

Link: https://lore.kernel.org/lkml/20191211104619.114557-1-oleksandr@redhat.com/

Link: https://lore.kernel.org/lkml/20220621133526.29662-1-mikoxyzzz@gmail.com/

…E_O3

1. Revert (a6036a4
   "kbuild: drop support for CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE_O3")
2. Mark -O3 as experimental, as it might cause unwanted regressions for
   users.
3. Allow all architectures to use the experimental -O3 optimization
   option. Previously, only ARC was allowed to use this option.

Link: https://lore.kernel.org/lkml/20191211104619.114557-1-oleksandr@redhat.com/
Signed-off-by: Oleksandr Natalenko <oleksandr@redhat.com>
Link: https://lore.kernel.org/lkml/20220621133526.29662-1-mikoxyzzz@gmail.com/
Signed-off-by: Miko Larsson <mikoxyzzz@gmail.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Makefile中新增的ifdef条件判断可能会导致KBUILD_CFLAGSKBUILD_RUSTFLAGS的值在不同的编译选项下不一致,需要确保这一改动不会影响现有功能。
  • init/Kconfig文件中新增的config CC_OPTIMIZE_FOR_PERFORMANCE_O3选项虽然提供了编译选项的灵活性,但应确保用户在尝试使用此选项时了解潜在的风险和后果。

是否建议立即修改:

  • 是,建议立即检查Makefileinit/Kconfig文件中的改动,并确保它们不会引入新的问题或混淆。同时,应该提供足够的文档和警告信息,提醒用户在使用这些特殊编译选项时需要谨慎。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avenger-285714 Avenger-285714 merged commit 4ed5435 into deepin-community:linux-6.6.y Sep 11, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants