Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Enable support for linkdata net card #405

Merged

Conversation

Avenger-285714
Copy link
Collaborator

No description provided.

This driver comes from WuXi Stars Micro System Technologies,
which provides support for linkdata ethernet card.

Signed-off-by: WangYuli <wangyuli@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
@Avenger-285714 Avenger-285714 merged commit 49f9874 into deepin-community:linux-6.6.y Sep 5, 2024
3 of 5 checks passed
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • arch/arm64/configs/deepin_arm64_desktop_defconfigarch/loongarch/configs/deepin_loongarch_desktop_defconfig中新增了CONFIG_WATCH_QUEUE配置项,需要确认是否有必要在所有架构上启用此功能,以及是否有相应的测试用例来验证其性能和稳定性。
  • arch/x86/configs/deepin_x86_desktop_defconfig中新增了CONFIG_OCTEON_EP配置项,需要验证该配置项是否适用于所有使用该架构的系统,并确保相关的开发人员了解这一变更。
  • 移除了CONFIG_CRYPTO_SM3_GENERIC配置项,需要确认这一变更是否会影响其他使用SM3算法的功能,以及是否有相应的测试用例来验证其正确性。
  • 新增了CONFIG_DEBUG_INFO_COMPRESSED_ZLIBCONFIG_DEBUG_INFO_BTF配置项,需要验证这些新配置项是否与现有的调试和构建系统兼容,并确保它们在开发过程中得到了充分的测试。
  • 删除了CONFIG_READABLE_ASM配置项,需要确认这一变更是否会影响开发人员对汇编代码的可读性,以及是否有替代方案来处理汇编代码的调试和分析。

是否建议立即修改:

  • 需要确保所有新增的配置项都经过了充分的测试,以避免引入新的错误或兼容性问题。
  • 需要与开发团队沟通这些配置项的变更,特别是与CONFIG_WATCH_QUEUECONFIG_OCTEON_EPCONFIG_CRYPTO_SM3_GENERICCONFIG_READABLE_ASM相关的变更,以避免对现有功能产生负面影响。
  • 应该添加相应的文档和注释,以便其他开发人员了解这些变更的原因和影响。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants