Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: ccp: Fix compile error on csv_cmd_buffer_len() #351

Merged

Conversation

Avenger-285714
Copy link
Collaborator

hygon inclusion
category: bugfix
CVE: NA


The error messages is shown as following:

drivers/crypto/ccp/hygon/csv-dev.c:21:5: error: no previous prototype for ‘csv_cmd_buffer_len’ [-Werror=missing-prototypes]
21 | int csv_cmd_buffer_len(int cmd)
| ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Reported-by: WangYuli wangyuli@uniontech.com

hygon inclusion
category: bugfix
CVE: NA

---------------------------

The error messages is shown as following:

drivers/crypto/ccp/hygon/csv-dev.c:21:5: error: no previous prototype for ‘csv_cmd_buffer_len’ [-Werror=missing-prototypes]
   21 | int csv_cmd_buffer_len(int cmd)
      |     ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Reported-by: WangYuli <wangyuli@uniontech.com>
Signed-off-by: hanliyang <hanliyang@hygon.cn>
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新添加的#include "csv-dev.h"中,需要确认该头文件是否存在并且包含所需的定义。
  • 检查是否有其他地方引用了"csv-dev.h",以避免潜在的重复包含问题。

是否建议立即修改:

  • 是,需要确保头文件的正确引入不会导致编译错误或运行时错误。

@Avenger-285714 Avenger-285714 merged commit 8a81afb into deepin-community:linux-6.6.y Aug 5, 2024
2 of 5 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yukarichiba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants