Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: stmmac: dwmac-phytium: compat some FT2000 #316

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Jul 9, 2024

Compat with some quirk platform FT2000/4 as id "FTGM0001", use rgmii-rxid instead of rgmii (wrong ACPI DSDT), and set dma_ops and host_dma_width (fix code style).

origin code in k4.19 is following:
acpi_dma_configure(priv->device,DEV_DMA_COHERENT); static u64 my_mask=0xffffffff;
priv->device->dma_mask = &my_mask;
priv->device->coherent_dma_mask = (u32)~0;
port to k5.10 add:
pdev->dev.dma_ops = NULL;

@opsiff opsiff force-pushed the opsiff-stmmac-phytium-2000 branch from ce44e0b to 5f68944 Compare July 9, 2024 09:39
Compat with some quirk platform FT2000/4 as id "FTGM0001",
use rgmii-rxid instead of rgmii (wrong ACPI DSDT),
and set dma_ops and host_dma_width (fix code style).

origin code in k4.19 is following:
acpi_dma_configure(priv->device,DEV_DMA_COHERENT);
static u64 my_mask=0xffffffff;
priv->device->dma_mask = &my_mask;
priv->device->coherent_dma_mask = (u32)~0;
port to k5.10 add:
pdev->dev.dma_ops = NULL;

Signed-off-by: Caicai <caizhaopeng@deepin.com>
Signed-off-by: hmy <huanglin@uniontech.com>
Signed-off-by: wenlunpeng <wenlunpeng@uniontech.com>
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@opsiff opsiff force-pushed the opsiff-stmmac-phytium-2000 branch from 5f68944 to 2f5bd34 Compare July 9, 2024 09:40
* Force this PHY mode to rgmii-rxid and info of its use.
* If the phy-mode rgmii is realy used, a blacklist may need to be added.
*/
if (acpi_match_device_ids(to_acpi_device(&pdev->dev), phytium_old_acpi_id) &&
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • phytium_dwmac_probe函数中,新增的ACPI设备ID匹配逻辑可能会影响现有功能,需要确认是否与现有代码库兼容。
  • phytium_dwmac_probe函数中,对pdev->dev.dma_ops的操作可能会导致DMA操作的不可用,需要确保这是预期的行为。
  • phytium_dwmac_probe函数中,新增了对plat->host_dma_width的赋值操作,需要确保这一改动不会影响其他模块或功能。
  • phytium_dwmac_probe函数中,新增了对plat->axi->axi_lpi_enplat->axi->axi_xit_frmplat->axi->axi_wr_osr_lmt的赋值操作,需要确保这些改动不会影响其他模块或功能。

是否建议立即修改:

  • 是,需要确保新增的代码逻辑不会引入新的问题,并且与现有的代码库兼容。同时,应该添加相应的注释来解释这些改动的目的和影响。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zccrs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zccrs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants