hda: phytium: Add Phytium hda driver support [New] #312
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Avenger-285714
force-pushed
the
phytium-hda
branch
from
7d918a3 to
9c956b1
Compare
sound/hda/hdac_stream.c
Outdated
| @@ -134,7 +134,11 @@ void snd_hdac_stream_start(struct hdac_stream *azx_dev) | |||
|
|
|||
| trace_snd_hdac_stream_start(bus, azx_dev); | |||
|
|
|||
| #ifdef CONFIG_SND_HDA_PHYTIUM | |||
| azx_dev->start_wallclk = snd_hdac_chip_readl(bus, WALLCLK) / 15; | |||
There was a problem hiding this comment.
这里/15和下面的/25是什么含义? 需要做read_cpuid_implementor隔离吧,不然会影响arm64的内核。
There was a problem hiding this comment.
这里是可以删掉的，实测不影响功能，这算是遗留的一个问题，主线一直没有去掉，建议直接去掉（/15和下面的/25）
There was a problem hiding this comment.
这里是可以删掉的，实测不影响功能，这算是遗留的一个问题，主线一直没有去掉，建议直接去掉（/15和下面的/25）
done.
| @@ -172,6 +175,42 @@ int snd_hdac_bus_send_cmd(struct hdac_bus *bus, unsigned int val) | |||
| bus->corb.buf[wp] = cpu_to_le32(val); | |||
| snd_hdac_chip_writew(bus, CORBWP, wp); | |||
|
|
|||
| if (bus->cmd_resend) { | |||
There was a problem hiding this comment.
个人认为按照主线标准的话 cmd_resend 相关的逻辑应该独立成一个 commit （以及变成位域这件事情真的不如直接 squash ……）
There was a problem hiding this comment.
个人认为按照主线标准的话 cmd_resend 相关的逻辑应该独立成一个 commit （以及变成位域这件事情真的不如直接 squash ……）
我这边的看法是尽量保留来自上下游厂商的原汁原味的补丁，如有异议再另行修改
This patch adds the Phytium hda driver support. Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn> Signed-off-by: Tian Wei <tianwei@phytium.com.cn> Reviewed-by: Wentao Guan <guanwentao@uniontech.com> Signed-off-by: WangYuli <wangyuli@uniontech.com>
A ':1' bit field gives the compiler the option to squeeze it in with other booleans, thereby optimizing memory usage. Suggested-by: Icenowy <uwu@icenowy.me> Signed-off-by: WangYuli <wangyuli@uniontech.com>
Avenger-285714
force-pushed
the
phytium-hda
branch
from
9c956b1 to
7e4e566
Compare
deepin pr auto reviewAdd Phytium HDA driver git-svn-id: 366494441966da344b4f78a40f55d24973fa8e5@1668 13f79535-47bb-0310-9956-ffa450edef68 |
Avenger-285714
merged commit d91779f
into
deepin-community:linux-6.6.y
This patch adds the Phytium hda driver support.