Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux-6.6.y] rtc: Fix set RTC time delay 500ms on some Zhaoxin SOCs #263

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

leoliu-oc
Copy link
Contributor

zhaoxin inclusion
category: bugfix


When the RTC divider is changed from reset to an operating time base, the first update cycle should be 500ms later. But on some Zhaoxin SOCs, this first update cycle is one second later. So set RTC time on these Zhaoxin SOCs will causing 500ms delay. Skip setup RTC divider on these SOCs in mc146818_set_time to fix it.

zhaoxin inclusion
category: bugfix

-------------------

When the RTC divider is changed from reset to an operating time base, the
first update cycle should be 500ms later. But on some Zhaoxin SOCs, this
first update cycle is one second later. So set RTC time on these Zhaoxin
SOCs will causing 500ms delay. Skip setup RTC divider on these SOCs in
mc146818_set_time to fix it.

Signed-off-by: leoliu-oc <leoliu-oc@zhaoxin.com>
@deepin-ci-robot
Copy link

Hi @leoliu-oc. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@opsiff opsiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@opsiff opsiff merged commit e180218 into deepin-community:linux-6.6.y Jun 19, 2024
2 of 3 checks passed
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • follow_mc146818_divider_reset函数中,对于特定CPU型号的检查逻辑可能不完整,应该考虑是否需要添加更多的条件判断。
  • apply_amd_register_a_behavior函数的调用未在代码更改中显示,如果这个函数的逻辑有所变化,可能会影响到相关代码的正确性。
  • mc146818_set_time函数中,follow_mc146818_divider_reset函数的调用逻辑有所变化,需要确保新的调用逻辑不会影响程序的正确性。
  • 代码中使用了#ifdef#endif来条件编译,这可能会导致代码可读性降低。可以考虑使用更清晰的条件逻辑或者将条件编译部分提取到单独的函数中。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: opsiff
Once this PR has been reviewed and has the lgtm label, please assign zccrs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants