-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iommu/arm-smmu-v3: Add suspend and resume support #236
iommu/arm-smmu-v3: Add suspend and resume support #236
Conversation
Hi @wangzhimin1179. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/* Saves the msg (base addr of msi irq) and restores it during resume */ | ||
desc->msg.address_lo = msg->address_lo; | ||
desc->msg.address_hi = msg->address_hi; | ||
desc->msg.data = msg->data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下面3222行只用到了address_hi和address_lo,这个data没用到? 是不是不用赋值?
2215d1c
to
4043b2e
Compare
已更新 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
这里有用到desc->msg->data 第一版本的是对的 |
Add suspend and resume support for smmuv3. The smmu is stopped when suspending and started when resuming. When the smmu is suspended, it is powered off and the registers are cleared. So saves the msi_msg context during msi interrupt initialization of smmu. When resume happens it calls arm_smmu_device_reset() to restore the registers. Closes: https://gitee.com/openeuler/kernel/issues/I4DZ7Q Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> Signed-off-by: Zhou Guanghui <zhouguanghui1@huawei.com> Reviewed-by: Hanjun Guo <guohanjun@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Wang Xu <wangxu@phytium.com.cn> Signed-off-by: Li Mingzhe <limingzhe1839@phytium.com.cn> Signed-off-by: Wang Zhimin <wangzhimin1179@phytium.com.cn>
4043b2e
to
9ce9ded
Compare
/ok-to-test |
deepin pr auto review关键摘要:
是否建议立即修改: |
Add suspend and resume support for smmuv3. The smmu is stopped when suspending and started when resuming.
When the smmu is suspended, it is powered off and the registers are cleared. So saves the msi_msg context during msi interrupt initialization of smmu. When resume happens it calls arm_smmu_device_reset() to restore the registers.
Closes: https://gitee.com/openeuler/kernel/issues/I4DZ7Q