Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input: Add a new serio driver for Phytium PCI PS/2 controller #200

Merged

Conversation

studyhu
Copy link

@studyhu studyhu commented May 24, 2024

This driver supports Phytium PCI PS/2 controller.

This driver supports Phytium PCI PS/2 controller.

Signed-off-by: Cheng Quan <chengquan@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Chen Zhenhua <chenzhenhua@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Signed-off-by: Hu Yeqing <huyeqing2074@phytium.com.cn>
@deepin-ci-robot
Copy link

Hi @studyhu. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign goldendeng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff
Copy link
Member

opsiff commented May 24, 2024

/ok-to-test

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • phytium_ps2_irq函数中,scancode的赋值应该在if语句的内部,否则在rxcount为0时scancode会被赋值为0,这可能导致后续的flag赋值不正确。
  • phytium_ps2_irq函数中的rxcount检查应该在循环外部,以确保在rxcount为0时能够正确地处理timeout interrupt。
  • phytium_ps2_write函数中的cpu_relax()调用可能是多余的,因为writel函数在Linux中会自动同步。
  • phytium_pci_ps2_probe函数中的ret变量在free分支中被赋值,但在out分支中没有被赋值,这可能导致未初始化的变量被使用。
  • phytium_pci_ps2_probe函数中的serio_register_port调用应该在kzalloc成功后立即进行,以确保在内存分配失败时能够正确释放资源。
  • phytium_pci_ps2_remove函数中的pcim_iounmap_regions调用应该在serio_unregister_port之后进行,以确保资源正确释放。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants