Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Markdown incorrectly rendering inline code blocks #2342

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jan 16, 2025

- Fixes deephaven#2312
- Tested using a code block from the ticket
@mofojed mofojed requested a review from dsmmcken January 16, 2025 02:07
@mofojed mofojed self-assigned this Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.69%. Comparing base (5f6c8d6) to head (9832a91).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...e-plugins/src/controls/markdown/MarkdownEditor.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2342      +/-   ##
==========================================
- Coverage   46.70%   46.69%   -0.01%     
==========================================
  Files         704      704              
  Lines       39044    39047       +3     
  Branches     9757     9759       +2     
==========================================
  Hits        18234    18234              
- Misses      20799    20802       +3     
  Partials       11       11              
Flag Coverage Δ
unit 46.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Should cut the horz padding in half when inline, it's using the same padding as block

@mofojed mofojed requested a review from dsmmcken January 16, 2025 19:28
@mofojed mofojed enabled auto-merge (squash) January 16, 2025 19:30
@mofojed mofojed merged commit f85c76f into deephaven:main Jan 16, 2025
12 checks passed
@mofojed mofojed deleted the DH-18434-fix-inline-code branch January 16, 2025 19:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown panel inline code created on new line
2 participants