Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for the getBaseTable API before calling it #2168

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jul 22, 2024

  • If it's not available, just fallback to the getKeyTable API (which we were using before)
  • Tested against deephaven-core 0.35.1
from deephaven import new_table

x = new_table({
    "Foo": [0, 1, 2, 0, 1, 2],
    "Bar": [4, 5, 6, 7, 8, 9]}
).partition_by(["Foo"])

- If it's not available, just fallback to the getKeyTable API (which we were using before)
- Tested against deephaven-core 0.35.1
```
from deephaven import new_table

x = new_table({
    "Foo": [0, 1, 2, 0, 1, 2],
    "Bar": [4, 5, 6, 7, 8, 9]}
).partition_by(["Foo"])
```
@mofojed mofojed self-assigned this Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.67%. Comparing base (b741f4e) to head (115f3cf).

Files Patch % Lines
...ges/iris-grid/src/IrisGridPartitionedTableModel.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2168      +/-   ##
==========================================
- Coverage   46.67%   46.67%   -0.01%     
==========================================
  Files         692      692              
  Lines       38622    38628       +6     
  Branches     9812     9839      +27     
==========================================
  Hits        18028    18028              
+ Misses      20583    20547      -36     
- Partials       11       53      +42     
Flag Coverage Δ
unit 46.67% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AkshatJawne AkshatJawne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mofojed mofojed merged commit a5cb947 into deephaven:main Jul 23, 2024
11 checks passed
@mofojed mofojed deleted the fix-partitioned-tables branch July 23, 2024 14:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants