Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enabled @typescript-eslint/return-await rule and fixed offending code #2157

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

bmingles
Copy link
Contributor

Enabled @typescript-eslint/return-await eslint rule and fixed offending code.

fixes #2154

BREAKING CHANGE: Fix any try / catch blocks that return non-awaited Promises

@bmingles bmingles requested a review from mofojed July 17, 2024 21:09
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.68%. Comparing base (958b011) to head (85268c8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2157      +/-   ##
==========================================
- Coverage   46.68%   46.68%   -0.01%     
==========================================
  Files         691      691              
  Lines       38587    38587              
  Branches     9622     9622              
==========================================
- Hits        18016    18014       -2     
- Misses      20560    20562       +2     
  Partials       11       11              
Flag Coverage Δ
unit 46.68% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles merged commit 7875d03 into deephaven:main Jul 22, 2024
11 checks passed
@bmingles bmingles deleted the 2154-return-awaited-promises branch July 22, 2024 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable linting rules for non-awaited Promises inside of try / catch
2 participants