Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back panel prop to IrisGrid Plugin #2155

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

AkshatJawne
Copy link
Contributor

@AkshatJawne AkshatJawne commented Jul 17, 2024

Closes #2093 (For now, will reopen ticket after merge for better solution to handle deprecated panel prop)

@AkshatJawne AkshatJawne requested a review from mofojed July 17, 2024 20:29
@AkshatJawne AkshatJawne self-assigned this Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.68%. Comparing base (de5ce40) to head (bf39dbc).
Report is 1 commits behind head on main.

Files Patch % Lines
...ashboard-core-plugins/src/panels/IrisGridPanel.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2155      +/-   ##
==========================================
- Coverage   46.68%   46.68%   -0.01%     
==========================================
  Files         691      691              
  Lines       38587    38588       +1     
  Branches     9806     9743      -63     
==========================================
  Hits        18016    18016              
+ Misses      20560    20519      -41     
- Partials       11       53      +42     
Flag Coverage Δ
unit 46.68% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AkshatJawne
Copy link
Contributor Author

Added current ticket number in TODO comment, and updated description to indicate that ticket will reopen after this merge to look at a more long-term, proper solution.

@AkshatJawne AkshatJawne requested a review from mofojed July 18, 2024 13:13
@AkshatJawne AkshatJawne merged commit 6362eb7 into deephaven:main Jul 18, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TablePlugin needs to know current grid selection, table name
2 participants