-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add filter prop to picker #2125
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so to sum up the problem a bit:
A
,B
, which results in the following table with four keys, E.g.A
should be0, 1
, andB
should be0, 1, 2
(size 0 is duplicated)A=1
, then the options forB
should just be0, 2
selectDistinct
with a partition column, so that we only get the unique options for that partition instead of duplicating items (like0
inB
).selectDistinct
to get the options for a partition column, we won't be able to filter it after that based on other partition columns, since we've only got that column in the outputted tableapplyFilter
before we callselectDistinct
.So I think this needs to be re-factored a bit. Right now we're building the
partitionTables
incomponentDidMount
only, but we should also be updating them afterhandlePartitionSelect
. Roughly what we should be doing...updatePartitionFilters
toupdatePartitionOptions
, and call it fromcomponentDidMount
instead of initializingpartitionTables
andpartitionFilters
in there (though we could still initialize thekeysTable
, and keep that around)updatePartitionFilters
, actually build thepartitionTables
by applying a filter to thekeysTable
first, then doing a.selectDistinct
(I think you can just doapplyFilter
and then call.selectDistinct
to get a new table)Let me know if that works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes implemented in latest push to #2110