Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ComboBoxNormalized - windowed data component #2072

Merged
merged 8 commits into from
Jun 19, 2024

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Jun 12, 2024

  • Created ComboBoxNormalized component. This component handles normalized item and section data which is needed to support windowed data. (there will be 1 more PR providing the ComboBox component in the jsapi-components package that will handle the table support. Similar to Picker)
  • Styleguide example showing controlled data + validation for no selection
  • Split out usePickerNormalizedProps hook from PickerNormalized so that the logic could be reused in ComboBoxNormalized
  • Cleaned up some generics for utils using Spectrum DomRef

resolves #2071

@bmingles bmingles marked this pull request as ready for review June 12, 2024 21:57
@bmingles bmingles changed the title feat: ComboBox - jsapi component feat: ComboBoxNormalized - windowed data component Jun 12, 2024
@bmingles bmingles requested a review from mofojed June 12, 2024 21:58
@bmingles bmingles self-assigned this Jun 12, 2024
@bmingles bmingles merged commit a30341a into deephaven:main Jun 19, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2024
@bmingles bmingles deleted the 2071-combobox-jsapi branch June 20, 2024 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComboBoxNormalized - @deephaven/components
2 participants