-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reconnect Auth Fail Fix - embed-widget #2023
fix: Reconnect Auth Fail Fix - embed-widget #2023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed this doesn't stop listening when the server is shutdown which is different behavior than what we currently have. I tested this by just stopping/starting the core server. The app showed the "auth failed" modal in that case. Previously this would just stay on the "Server shutdown" component.
@mattrunyon Have been testing on my local branch, not able to reproduce, when I shut down the core server and start it again, I do not see the "auth failed" modal, it just stays on the "Server shutdown". |
Changed test case based on new logic, until the connection is resolved, it will show the modal, and hence for the first assertion of the connection bootstrap, should not be null. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will still need @mofojed to review again. I want to make sure he's ok w/ the state names as well.
Changes for the states could be not_connecting
-> errored
. And failed
-> authFailed
instead. I'm indifferent though
Resolves #1256
Changes Implemented:
ConnectionBootstrap
in order to properly handle auth fail event in theembed-widget
Visual of modal that appears on auth fail: