fix: Use picker for iris grid partition selector #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmmcken
requested changes
May 14, 2024
mofojed
requested changes
May 14, 2024
mofojed
previously approved these changes
May 15, 2024
Comment on lines
308
to
315
| label={column.name} | ||
| table={partitionTables[index]} | ||
| direction="bottom" | ||
| shouldFlip={false} | ||
| keyColumn={partitionTables[index].columns[index].name} | ||
| placeholder={'Loading...' as string} | ||
| labelColumn={partitionTables[index].columns[index].name} | ||
| labelPosition="side" |
There was a problem hiding this comment.
I would've probably grouped the label and labelPosition props together (since they're both labelling the component), but 🤷
There was a problem hiding this comment.
My bad, I thought I should have labelColumn and labelPosition together, but what you have mentioned makes sense, since the labelColumn is referring to something else. Should be good now
mofojed
approved these changes
May 16, 2024
|
@dsmmcken Could you take another look at this whenever you have the time, so that I can merge? |
dsmmcken
approved these changes
May 16, 2024
|
Thanks Don, merging now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1970
Changes Implemented:
Testing Information:
Code used:
Sample visual of new Picker:
