perf: Improve performance of lots of grids in a dashboard #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
May 3, 2024
mofojed
commented
- Each GridRenderer had an independent cache for checking various colour operations, instead use a shared cache
- Grids are likely to share the same colours because they have similar themes anyway
- Improves performance when opening dashboards with lots of grids
- Each GridRenderer had an independent cache for checking various colour operations, instead use a shared cache - Grids are likely to share the same colours because they have similar themes anyway - Improves performance when opening dashboards with lots of grids
|
Another idea I've had is making a shared cache for every measure text call. The cache would need to be keyed on both the current context.font + string being measured, but tables frequently repeat values internally and across tables, and measureText is rather expensive. |
mattrunyon
requested changes
May 7, 2024
mattrunyon
approved these changes
May 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.