fix: Downgrade Spectrum to 3.33.1 #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmingles
force-pushed
the
1976-downgrade-spectrum
branch
from
3ec4509
to
747fc39
Compare
dsmmcken
requested changes
May 1, 2024
dsmmcken
reviewed
May 1, 2024
Comment on lines
46
to
105
| const numberToName: Record<string, string> = { | ||
| 0: '', | ||
| 1: 'One', | ||
| 2: 'Two', | ||
| 3: 'Three', | ||
| 4: 'Four', | ||
| 5: 'Five', | ||
| 6: 'Six', | ||
| 7: 'Seven', | ||
| 8: 'Eight', | ||
| 9: 'Nine', | ||
| 10: 'Ten', | ||
| 11: 'Eleven', | ||
| 12: 'Twelve', | ||
| 13: 'Thirteen', | ||
| 14: 'Fourteen', | ||
| 15: 'Fifteen', | ||
| 16: 'Sixteen', | ||
| 17: 'Seventeen', | ||
| 18: 'Eighteen', | ||
| 19: 'Nineteen', | ||
| 20: 'Twenty', | ||
| 30: 'Thirty', | ||
| 40: 'Forty', | ||
| 50: 'Fifty', | ||
| 60: 'Sixty', | ||
| 70: 'Seventy', | ||
| 80: 'Eighty', | ||
| 90: 'Ninety', | ||
| } as const; | ||
|
|
||
| function createOptions() { | ||
| const options = []; | ||
|
|
||
| for (let hundreds = 0; hundreds <= 200; hundreds += 100) { | ||
| for (let tens = 0; tens <= 90; tens += 10) { | ||
| for (let ones = 0; ones <= 9; ones += 1) { | ||
| if (hundreds > 0 || tens > 0 || ones > 0) { | ||
| const value = String(hundreds + tens + ones); | ||
|
|
||
| const tensAndOnes = | ||
| tens <= 10 | ||
| ? numberToName[tens + ones] | ||
| : `${numberToName[tens]} ${numberToName[ones]}`; | ||
|
|
||
| const title = | ||
| hundreds === 0 | ||
| ? tensAndOnes | ||
| : `${numberToName[hundreds / 100]} Hundred ${tensAndOnes}`; | ||
|
|
||
| options.push({ title, value }); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return options; | ||
| } | ||
|
|
||
| const options = createOptions(); |
There was a problem hiding this comment.
This a lot of code that we don't really need to be so fancy and provides no real value. Item ${i} would be more than enough.
There was a problem hiding this comment.
was trying to avoid having to change e2e snapshot, but that's fair. I may just remove it since it didn't produce the original problem anyway
bmingles
force-pushed
the
1976-downgrade-spectrum
branch
from
747fc39
to
058ee0b
Compare
dsmmcken
approved these changes
May 1, 2024
|
@bmingles This should have been marked as a I've manually added to release notes as a fix. |
bmingles
changed the title
|
@mofojed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgraded Spectrum to 3.33.1 to fix Combobox scrolling.
resolves #1976