Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Typing in notebooks is laggy #1977

Merged
merged 8 commits into from
May 2, 2024
Merged

fix: Typing in notebooks is laggy #1977

merged 8 commits into from
May 2, 2024

Commits on May 1, 2024

  1. fix: Typing in notebooks is laggy 

    - We were checking the diff of the layouts on each keystroke
- DashboardLayout should debounce checking that diff
- Tested by displaying FPS counter, having a Code Studio with a bunch of tables in it, adding a notebook, and then typing in it. FPS is much higher after the change
    @mofojed
    mofojed committed May 1, 2024
    Configuration menu
    Copy the full SHA
    d042c3c View commit details
    Browse the repository at this point in the history

  2. Change to a throttled instead of debounced 

    - Otherwise it's possible for a dashboard to never save if it is constantly updating
    @mofojed
    mofojed committed May 1, 2024
    Configuration menu
    Copy the full SHA
    2c57223 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Add useThrottledCallback hook

    @mofojed
    mofojed committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c318d92 View commit details
    Browse the repository at this point in the history

  2. Clean up useThrottledCallback

    @mofojed
    mofojed committed May 2, 2024
    Configuration menu
    Copy the full SHA
    af19103 View commit details
    Browse the repository at this point in the history

  3. Flush the throttled callback

    @mofojed
    mofojed committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6e303eb View commit details
    Browse the repository at this point in the history

  4. Clean up useThrottledCallback and tests 

    - Need to use refs so that the callbacks don't change each time, and the flush/cancel are stable
- Fun!
    @mofojed
    mofojed committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f7e61d6 View commit details
    Browse the repository at this point in the history

  5. Clean up from review, update comments

    @mofojed
    mofojed committed May 2, 2024
    Configuration menu
    Copy the full SHA
    dfd35ca View commit details
    Browse the repository at this point in the history

  6. Address review comments

    @mofojed
    mofojed committed May 2, 2024
    Configuration menu
    Copy the full SHA
    1739edb View commit details
    Browse the repository at this point in the history