Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Picker - formatter settings #1907

Merged
merged 10 commits into from
Apr 3, 2024
Merged

feat: Picker - formatter settings #1907

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0d7755c
Formatter settings from context (#1889)
bmingles Mar 27, 2024
c4f9e73
Comments (#1889)
bmingles Mar 27, 2024
94cf75d
Simplified formatter settings (#1889)
bmingles Mar 28, 2024
edd261e
Split out util function (#1889)
bmingles Mar 28, 2024
de2aa6d
Tests (#1889)
bmingles Mar 28, 2024
fe09fa6
useGetItemIndexByValue error handling (#1889)
bmingles Mar 28, 2024
c032c9b
Added settings to dependency array to update selection on settings ch…
bmingles Mar 28, 2024
903d03c
Rethrow error (#1889)
bmingles Apr 3, 2024
1e86dc6
Fixed test (#1889)
bmingles Apr 3, 2024
4163862
Removed catch + log (#1889)
bmingles Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/jsapi-components/src/useGetItemIndexByValue.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe('useGetItemIndexByValue', () => {
}
);

it('should return null if seekRow fails', async () => {
it('should throw if seekRow fails', async () => {
asMock(mockTable.seekRow).mockRejectedValue('Some error');

const { result } = renderHook(() =>
Expand All @@ -65,9 +65,7 @@ describe('useGetItemIndexByValue', () => {
})
);

const actual = await result.current();

expect(actual).toBeNull();
expect(result.current()).rejects.toEqual('Some error');
});

it.each([
Expand Down
2 changes: 1 addition & 1 deletion packages/jsapi-components/src/useGetItemIndexByValue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function useGetItemIndexByValue<TValue>({
return index === -1 ? null : index;
} catch (err) {
log.debug('Error seeking row', { column, value, columnValueType });
return null;
throw err;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't bother logging it either - consumer either catches it and logs it or does something with it in which case the log would be extra spam. If it's uncaught would be logged as an uncaught promise anyway.

}
}, [columnName, table, tableUtils, value]);
}
Expand Down
Loading