Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Picker - Table support for key + label columns #1876

Merged
merged 40 commits into from
Mar 27, 2024
Merged

feat: Picker - Table support for key + label columns #1876

merged 40 commits into from
Mar 27, 2024

Commits on Mar 27, 2024

  1. Use KeyedItem interface in Picker (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a8c773a View commit details
    Browse the repository at this point in the history

  2. Added reuseItemsOnTableResize param (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    03191ce View commit details
    Browse the repository at this point in the history

  3. Support passing NormalizedPickerItem[] to Picker (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c65ebce View commit details
    Browse the repository at this point in the history

  4. Tests (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    eafc98c View commit details
    Browse the repository at this point in the history

  5. Updated comment (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3b4ed94 View commit details
    Browse the repository at this point in the history

  6. Added item key prefix (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    bb7d4ba View commit details
    Browse the repository at this point in the history

  7. Scroll area utils (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5a3d852 View commit details
    Browse the repository at this point in the history

  8. Windowed scrolling (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f37d2f2 View commit details
    Browse the repository at this point in the history

  9. Scroll when popover opens (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5ac92e2 View commit details
    Browse the repository at this point in the history

  10. Simplified scroll to position (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e063389 View commit details
    Browse the repository at this point in the history

  11. JS api Picker component (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    69afe60 View commit details
    Browse the repository at this point in the history

  12. Fixed a bug with selectedKey types always being strings (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d668beb View commit details
    Browse the repository at this point in the history

  13. Updated e2e snapshots (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1a4f98c View commit details
    Browse the repository at this point in the history

  14. Fixed tests (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    920ae45 View commit details
    Browse the repository at this point in the history

  15. selectedKey + defaultSelectedKey support (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e7b112d View commit details
    Browse the repository at this point in the history

  16. Updated e2e snapshots (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    31c7d2e View commit details
    Browse the repository at this point in the history

  17. Fixed tests (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    aa840a4 View commit details
    Browse the repository at this point in the history

  18. Remove top-level key (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    539a0fe View commit details
    Browse the repository at this point in the history

  19. Tests (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    af14c98 View commit details
    Browse the repository at this point in the history

  20. Cleanup (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    9b961dd View commit details
    Browse the repository at this point in the history

  21. Tests (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    89952ad View commit details
    Browse the repository at this point in the history

  22. Label (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2f9a5fa View commit details
    Browse the repository at this point in the history

  23. getPositionOfSelectedItem (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    8323201 View commit details
    Browse the repository at this point in the history

  24. usePopoverOnScrollRef tests (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2b94503 View commit details
    Browse the repository at this point in the history

  25. label (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    613fc6c View commit details
    Browse the repository at this point in the history

  26. Comment (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a94aeb7 View commit details
    Browse the repository at this point in the history

  27. Comment (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    491c275 View commit details
    Browse the repository at this point in the history

  28. PickerUtils tests (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    40b08dd View commit details
    Browse the repository at this point in the history

  29. Fixed scroll to item on subsequent popover opens (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a58678b View commit details
    Browse the repository at this point in the history

  30. getValueType tests (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    275378a View commit details
    Browse the repository at this point in the history

  31. useGetItemIndexByValue test (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    8f58c19 View commit details
    Browse the repository at this point in the history

  32. test label (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    11d0750 View commit details
    Browse the repository at this point in the history

  33. Fixed boolean mapping (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d3327f5 View commit details
    Browse the repository at this point in the history

  34. Re-arranged test (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4d117a8 View commit details
    Browse the repository at this point in the history

  35. Removed children prop (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    982c839 View commit details
    Browse the repository at this point in the history

  36. Default Formatter (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    39d57d2 View commit details
    Browse the repository at this point in the history

  37. Tweaked test (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    fad37c9 View commit details
    Browse the repository at this point in the history

  38. Addressed review comments (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    290d2ff View commit details
    Browse the repository at this point in the history

  39. Added catch for promise (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    435b095 View commit details
    Browse the repository at this point in the history

  40. Logger namespace (deephaven#1858)

    @bmingles
    bmingles committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4b70ed0 View commit details
    Browse the repository at this point in the history