Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proxy #187

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Fix proxy #187

merged 2 commits into from
Sep 7, 2021

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Sep 7, 2021

  • Revert "Using the http-proxy-middleware to proxy (Using the http-proxy-middleware to proxy #180)" (proxied everything so wasn't even using dev version of the app, hot reloading doesn't seem to work with setupProxy.js file setup).
  • Setup proxy using package.json

@mofojed
Revert "Using the http-proxy-middleware to proxy (deephaven#180)"
7c69bf5 
This reverts commit 21663a2.
@mofojed
Setup proxy using package.json
160a478 
Need to leave the jsapi bit in .env.development though
@mofojed mofojed requested a review from dsmmcken September 7, 2021 13:12
@mofojed mofojed self-assigned this Sep 7, 2021
@dsmmcken dsmmcken merged commit e4d31eb into deephaven:main Sep 7, 2021
mofojed added a commit to mofojed/web-client-ui that referenced this pull request Sep 13, 2021
@mofojed
v0.3.2
9f054e1 
* `code-studio`, `console`, `file-explorer`
  * [deephaven#186](deephaven#186) Enable Scala syntax highlighting ([@nbauernfeind](https://github.com/nbauernfeind))
* `components`, `grid`, `iris-grid`
  * [deephaven#174](deephaven#174) Make scrollbar styling consistent ([@dsmmcken](https://github.com/dsmmcken))

* `console`, `iris-grid`
  * [deephaven#179](deephaven#179) Update monaco-editor to 0.27.0 ([@mofojed](https://github.com/mofojed))

* `code-studio`
  * [deephaven#187](deephaven#187) Fix proxy ([@mofojed](https://github.com/mofojed))

- Don ([@dsmmcken](https://github.com/dsmmcken))
- Mike Bender ([@mofojed](https://github.com/mofojed))
- Nate Bauernfeind ([@nbauernfeind](https://github.com/nbauernfeind))
@mofojed mofojed mentioned this pull request Sep 13, 2021
Merged
mofojed added a commit that referenced this pull request Sep 13, 2021
@mofojed
v0.3.2 (#195)
9394a1d 
* `code-studio`, `console`, `file-explorer`
  * [#186](#186) Enable Scala syntax highlighting ([@nbauernfeind](https://github.com/nbauernfeind))
* `components`, `grid`, `iris-grid`
  * [#174](#174) Make scrollbar styling consistent ([@dsmmcken](https://github.com/dsmmcken))

* `console`, `iris-grid`
  * [#179](#179) Update monaco-editor to 0.27.0 ([@mofojed](https://github.com/mofojed))

* `code-studio`
  * [#187](#187) Fix proxy ([@mofojed](https://github.com/mofojed))

- Don ([@dsmmcken](https://github.com/dsmmcken))
- Mike Bender ([@mofojed](https://github.com/mofojed))
- Nate Bauernfeind ([@nbauernfeind](https://github.com/nbauernfeind))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsmmcken dsmmcken dsmmcken approved these changes

Assignees

@mofojed mofojed

Labels
internal web-client-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mofojed @dsmmcken