fix: Load default dashboard data from workspace data #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Feb 15, 2024
mofojed
commented
- Until we have support for Persist multiple dashboards #1746 , load the default dashboard data from workspace
- Needed for testing the widget hydration PR
- Tested with my changes for widget hydration
- Ensured deephaven.ui widgets re-opened upon refresh
- Ensured links remained between existing tables
- We need to store the Dashboard data in dashboard storage which doesn't exist in Community
- Needed to load filterSets and links from there still
- There's a different layout for each dashboard, so store the map of them that we're listening to
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1810 +/- ##
==========================================
- Coverage 46.05% 45.98% -0.08%
==========================================
Files 628 631 +3
Lines 37771 37862 +91
Branches 9512 9535 +23
==========================================
+ Hits 17394 17409 +15
- Misses 20323 20399 +76
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattrunyon
reviewed
Feb 20, 2024
Comment on lines
+5
to
+8
| export interface CreateDashboardPayload<T = unknown> { | ||
| pluginId: string; | ||
| title: string; | ||
| data: unknown; | ||
| data: T; |
There was a problem hiding this comment.
Why the generic? The data comes from the plugin and we only really care it's serializable
There was a problem hiding this comment.
So the listen/emit events can add typing for payload. For the emit function which will come from the plugin, can add typing so we know we're not passing a malformed payload.
mattrunyon
reviewed
Feb 26, 2024
mattrunyon
approved these changes
Feb 28, 2024
mofojed
added a commit
to deephaven/deephaven-plugins
that referenced
this pull request
Feb 28, 2024
- Reload widgets on dashboard reload - Needs my draft PR that stores default dashboard data with the workspace for this to work (deephaven/web-client-ui#1810) - Opened deephaven.ui widgets from the examples, then refreshed the page. Widgets re-opened in the same positions/panels they were in. Widget internal state (such as input in a text field, or filter set on a table) and ui.dashboards do _not_ re-hydrate correctly yet - ui.dashboard will do after dashboard storage is properly done, but that shouldn't be needed for this to work in Enterprise - Fixes #160 - Fixes #161 - Fixes #162
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.