fix: Load full uncoalesced table if no partition columns available #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Feb 1, 2024
mofojed
commented
- When there are no partition columns, we should just load the whole table instead of hanging
- Tested with the snippet in the ticket
- Fixes Uncoalesced tables with no partitioning columns do not render #1763
- When there are no partition columns, we should just load the whole table instead of hanging - Tested with the snippet in the ticket - Fixes deephaven#1763
mattrunyon
approved these changes
Feb 1, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1767 +/- ##
==========================================
- Coverage 46.06% 46.06% -0.01%
==========================================
Files 626 626
Lines 37593 37596 +3
Branches 9458 9460 +2
==========================================
+ Hits 17318 17319 +1
- Misses 20220 20222 +2
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.