Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added dashboard-core-plugins to remote-component list #1762

Merged

Conversation

bmingles
Copy link
Contributor

Including dashboard-core-plugins to remote-component list so we can externalize it in plugins repo when developing js plugins.

supports #1728

@bmingles bmingles linked an issue Jan 30, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cb0a10) 45.99% compared to head (f8ec0b0) 45.99%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1762   +/-   ##
=======================================
  Coverage   45.99%   45.99%           
=======================================
  Files         626      626           
  Lines       37576    37576           
  Branches     9450     9450           
=======================================
  Hits        17284    17284           
  Misses      20237    20237           
  Partials       55       55           
Flag Coverage Δ
unit 45.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the linked issue since it doesn't actually fix the issue. Don't want it to close incorrectly

@bmingles bmingles merged commit 3194c4b into deephaven:main Jan 31, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
@bmingles bmingles deleted the 1728-dashboard-core-plugins-remote-component branch January 31, 2024 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants