-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multiselect values #1736
Merged
wusteven815
merged 23 commits into
deephaven:main
from
wusteven815:feat-1233-multiselect
Feb 6, 2024
Merged
feat: multiselect values #1736
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
106bb5f
feat: add util to create logical normal forms
wusteven815 38fc9e5
feat: add not empty assert
wusteven815 66af19f
feat: multiselect rows in grid
wusteven815 eff26eb
feat: add missing empty string, fix texts
wusteven815 119a4f3
test: add multiselect tests
wusteven815 c5c9bdf
test: update multiselect snapshots
wusteven815 f91e6e6
test: add for non empty arrays
wusteven815 38d1b0c
fix(multiselect): non-selected right click won't use range
wusteven815 3cde604
test: add more multiselect tests
wusteven815 cf9c519
feat: right click changes selection
wusteven815 5ff2849
feat: change number filter behaviour and comments
wusteven815 d397a4f
test(multiselect): update for new string behaviour
wusteven815 4d5aaae
fix: only select on right click if row exists
wusteven815 6073a28
style: remove commented out code
wusteven815 3b6f923
style: remove commented out code
wusteven815 dbf9083
Merge branch 'deephaven:main' into feat-1233-multiselect
wusteven815 22f0d6d
refactor: use map/joins instead of makeLogicalNormalForm
wusteven815 df9db47
refactor: use contains cell helper function instead
wusteven815 cae022e
refactor: remove drag bounds, simplify selection
wusteven815 ac17b34
refactor: simplify truncating algorithm
wusteven815 5e97786
test: add unit test for right click behaviour
wusteven815 a47b9ff
Merge branch 'deephaven:main' into feat-1233-multiselect
wusteven815 15bca84
feat: assertion refactors
wusteven815 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Binding this here is not strictly necessary, as
getSelectedRanges
isn't passed in anywhere. Should just be able to callgrid.getSelectedRanges
directly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting
TypeError: Cannot read properties of undefined (reading 'state')
when I'm not binding it. I believe it's because the function is readingselectedRanges
fromthis.state
.