Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Default to Skip operation instead of Sum operation #1648

Merged
merged 5 commits into from
Nov 23, 2023
Merged

fix: Default to Skip operation instead of Sum operation #1648

merged 5 commits into from
Nov 23, 2023

Commits on Nov 20, 2023

  1. Remove duplicated function 

    - It's already defined in IrisGridTableModelTemplate which this class extends, and was the exact same code
    @mofojed
    mofojed committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0b45a6c View commit details
    Browse the repository at this point in the history

  2. Use the Skip aggregation operation by default 

    - Unless the user specifies it, we should just skip it
    @mofojed
    mofojed committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    d754241 View commit details
    Browse the repository at this point in the history

  3. Clean up unused code

    @mofojed
    mofojed committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    bececf6 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Address review comments 

    - Now if you deselect all of the columns for an aggregation, it will filter out that column from the config that it applies
- Will also remove from the aggregations list entirely
    @mofojed
    mofojed committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ce73663 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Remove empty aggregations only when editing is done 

    - So the order stays stable
    @mofojed
    mofojed committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    ad9b819 View commit details
    Browse the repository at this point in the history