Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add LayoutManagerContext and useLayoutManager #1625

Merged
merged 7 commits into from
Nov 8, 2023

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Nov 6, 2023

  • Each dashboard provides the LayoutManagerContext

@mofojed mofojed self-assigned this Nov 6, 2023
@mofojed mofojed enabled auto-merge (squash) November 6, 2023 19:35
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d5b3b48) 46.70% compared to head (b21ac6f) 46.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1625      +/-   ##
==========================================
- Coverage   46.70%   46.70%   -0.01%     
==========================================
  Files         587      589       +2     
  Lines       36349    36355       +6     
  Branches     9099     9100       +1     
==========================================
+ Hits        16977    16978       +1     
- Misses      19320    19325       +5     
  Partials       52       52              
Flag Coverage Δ
unit 46.70% <37.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/app-utils/src/plugins/remote-component.config.ts 100.00% <ø> (ø)
packages/dashboard/src/Dashboard.tsx 89.36% <100.00%> (ø)
...kages/dashboard/src/layout/LayoutManagerContext.ts 100.00% <100.00%> (ø)
...ackages/iris-grid/src/TreeTableViewportUpdater.tsx 0.00% <ø> (ø)
packages/jsapi-components/src/useTableListener.ts 100.00% <100.00%> (ø)
packages/plugin/src/PluginTypes.ts 50.00% <ø> (ø)
packages/dashboard/src/layout/useLayoutManager.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Each dashboard provied the LayoutContext
- So that plugins can use the same LayoutManagerContext
- JsWidget was redundant of Widget
- Combined with the Widget interface and removed the redundant interface
- JsWidget => Widget
- EventListener is now generic and can be typed
@mofojed mofojed changed the title feat: Add LayoutContext and useLayout feat: Add LayoutManagerContext and useLayout Nov 8, 2023
@mofojed mofojed changed the title feat: Add LayoutManagerContext and useLayout feat: Add LayoutManagerContext and useLayoutManager Nov 8, 2023
@mattrunyon mattrunyon enabled auto-merge (squash) November 8, 2023 20:52
@mattrunyon mattrunyon merged commit 0a6965a into deephaven:main Nov 8, 2023
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants