-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add LayoutManagerContext
and useLayoutManager
#1625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrunyon
reviewed
Nov 6, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1625 +/- ##
==========================================
- Coverage 46.70% 46.70% -0.01%
==========================================
Files 587 589 +2
Lines 36349 36355 +6
Branches 9099 9100 +1
==========================================
+ Hits 16977 16978 +1
- Misses 19320 19325 +5
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mattrunyon
requested changes
Nov 7, 2023
mattrunyon
requested changes
Nov 8, 2023
- Each dashboard provied the LayoutContext
- So that plugins can use the same LayoutManagerContext
- JsWidget was redundant of Widget - Combined with the Widget interface and removed the redundant interface
- JsWidget => Widget - EventListener is now generic and can be typed
mofojed
force-pushed
the
layout-context
branch
from
November 8, 2023 17:09
3515601
to
5915f16
Compare
mofojed
changed the title
feat: Add
feat: Add Nov 8, 2023
LayoutContext
and useLayout
LayoutManagerContext
and useLayout
mofojed
changed the title
feat: Add
feat: Add Nov 8, 2023
LayoutManagerContext
and useLayout
LayoutManagerContext
and useLayoutManager
mattrunyon
approved these changes
Nov 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayoutManagerContext