Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert util TextUtils to TS #16

Merged
merged 2 commits into from
May 20, 2021
Merged

convert util TextUtils to TS #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c1944f
convert util TextUtils to TS
spasovski May 7, 2021
c5243f4
address review comments
spasovski May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions packages/utils/src/TextUtils.js → packages/utils/src/TextUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ class TextUtils {
* One
* One and Two
* One, Two, and Three
* @param {String[]} items The items to join in a list
* @param items The items to join in a list
*/
static join(items) {
static join(items: string[] | null): string {
if (items == null || items.length === 0) {
return '';
}
Expand All @@ -27,10 +27,10 @@ class TextUtils {

/**
* Converts text to lower case, handling null if necessary and returning an empty string
* @param {String} text The text to convert to lower case
* @param {Boolean} isNullAllowed True if a null string should return an empty string from this function. If false an error is thrown if null is passed in.
* @param text The text to convert to lower case
* @param isNullAllowed True if a null string should return an empty string from this function. If false an error is thrown if null is passed in.
*/
static toLower(text, isNullAllowed = true) {
static toLower(text: string | null, isNullAllowed = true): string {
if (text == null) {
if (isNullAllowed) {
return '';
Expand All @@ -44,11 +44,11 @@ class TextUtils {

/**
*
* @param {String} a The string to sort
* @param {String} b Second string to sort
* @param {boolean} isAscending Whether to sort ascending or descending
* @param a The string to sort
* @param b Second string to sort
* @param isAscending Whether to sort ascending or descending
*/
static sort(a, b, isAscending = true) {
static sort(a: string, b: string, isAscending = true): number {
if (a < b) {
return isAscending ? -1 : 1;
}
Expand Down