Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use user permissions for iframes instead of query parameters #1400

Merged
merged 6 commits into from
Jul 7, 2023
Merged

fix: Use user permissions for iframes instead of query parameters #1400

merged 6 commits into from
Jul 7, 2023

Commits on Jul 6, 2023

  1. Add UserUtils for fetching the User 

    - Added tests for it as well
- Updated the embed readmes to link to Application mode correctly
    @mofojed
    mofojed committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    168e7f0 View commit details
    Browse the repository at this point in the history

  2. WIP Refactoring things a little bit...

    @mofojed
    mofojed committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    fe4a4ef View commit details
    Browse the repository at this point in the history

  3. Add UserContext to AppBootstrap 

    - Now after the user has completed authentication, the user context is also bootstrapped
- Wired up in embed-grid, and got rid of the canCopy/canDownloadCsv query parameters
    @mofojed
    mofojed committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    494b855 View commit details
    Browse the repository at this point in the history

  4. Don't normalize the type before applying it to IrisGrid 

    - Not sure why I was
    @mofojed
    mofojed committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    5cd7868 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Clean up based on review 

    - Remove Enterprise permissions from the community user permissions
- Clean up how we retrieved a boolean value in tests
- Fix error message
    @mofojed
    mofojed committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    35f9fd6 View commit details
    Browse the repository at this point in the history

  2. Missed a couple instances

    @mofojed
    mofojed committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    25e448e View commit details
    Browse the repository at this point in the history