Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-14972 Remove setSearch debounce in CommandHistoryViewportUpdater #1351

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Jun 6, 2023

There was an issue with Enterprise command history, where applyFilters method was called on the history table after setViewport, because of the setSearch debounce.

Fixed by moving the debounce to the parent component.

@vbabich vbabich self-assigned this Jun 6, 2023
@vbabich vbabich requested a review from mofojed June 6, 2023 15:49
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1351 (d842961) into main (02b8d4f) will increase coverage by 0.00%.
The diff coverage is 42.85%.

@@           Coverage Diff           @@
##             main    #1351   +/-   ##
=======================================
  Coverage   45.95%   45.95%           
=======================================
  Files         494      494           
  Lines       34422    34423    +1     
  Branches     8587     8587           
=======================================
+ Hits        15817    15820    +3     
+ Misses      18554    18552    -2     
  Partials       51       51           
Flag Coverage Δ
unit 45.95% <42.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../command-history/CommandHistoryViewportUpdater.tsx 0.00% <0.00%> (ø)
...ges/console/src/command-history/CommandHistory.tsx 46.66% <50.00%> (+0.57%) ⬆️

... and 1 file with indirect coverage changes

@vbabich vbabich merged commit 2601146 into deephaven:main Jun 6, 2023
@vbabich vbabich deleted the remove-setsearch-debounce branch June 6, 2023 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants