Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "refactor: Clean up golden-layout css (#1322)" #1334

Merged
merged 1 commit into from
May 31, 2023
Merged

revert: "refactor: Clean up golden-layout css (#1322)" #1334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions packages/dashboard/src/PanelPlaceholder.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,9 @@
display: flex;
flex-direction: column;
justify-content: center;
padding: $spacer-3;
min-height: 100%;
max-height: 100%;
text-align: center;
overflow: hidden;

// add padding on an inner wrapper so it is included in max height of parent
div {
padding: $spacer-3;
}
}
2 changes: 1 addition & 1 deletion packages/dashboard/src/PanelPlaceholder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const PanelPlaceholder = React.forwardRef(
const component = LayoutUtils.getComponentNameFromPanel({ props });
return (
<div ref={ref} className="panel-placeholder">
<div>Component &quot;{component}&quot; is not registered.</div>
Component &quot;{component}&quot; is not registered.
</div>
);
}
Expand Down
9 changes: 9 additions & 0 deletions packages/dashboard/src/layout/GoldenLayout.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
@import '@deephaven/components/scss/custom.scss';
@import './GoldenLayout.scss';

// Exported variables for use in GoldenLayoutThemeExport.js
/* stylelint-disable property-no-unknown */
:export {
tab-height: $tab-height;
drag-border-width: $drag-border-width;
}
Loading