build: Use Vite HTML env variable replacement #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1304 +/- ##
=======================================
Coverage 45.89% 45.89%
=======================================
Files 492 492
Lines 34371 34371
Branches 8566 8566
=======================================
Hits 15775 15775
Misses 18545 18545
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. |
mofojed
approved these changes
May 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1161
Also fixed an embed-grid/embed-chart Vite proxy server issue in preview mode
Tested by running
npm startand looking at those tags in the head which should be replaced (base, npm version, favicon). Then rannpm run buildandnpm run previewand checked the tags in the built version