Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Double clicking a file causes the loader to flash incorrectly #1189

Merged
merged 5 commits into from
Mar 31, 2023
Merged

fix: Double clicking a file causes the loader to flash incorrectly #1189

merged 5 commits into from
Mar 31, 2023

Conversation

mattrunyon
Copy link
Collaborator

Fixes #942

@mattrunyon mattrunyon requested a review from mofojed March 30, 2023 15:35
@mattrunyon mattrunyon self-assigned this Mar 30, 2023
@mattrunyon mattrunyon mentioned this pull request Mar 30, 2023
Merged
@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

Merging #1189 (b5f0199) into main (4870171) will decrease coverage by 0.01%.
The diff coverage is 3.57%.

@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
- Coverage   44.20%   44.20%   -0.01%     
==========================================
  Files         448      448              
  Lines       33432    33439       +7     
  Branches     8403     8406       +3     
==========================================
+ Hits        14780    14781       +1     
- Misses      18602    18608       +6     
  Partials       50       50
Flag Coverage Δ
unit 44.20% <3.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/dashboard-core-plugins/src/ConsolePlugin.tsx 20.83% <0.00%> (-0.09%) ⬇️
...ashboard-core-plugins/src/panels/NotebookPanel.tsx 1.59% <0.00%> (-0.02%) ⬇️
...dashboard-core-plugins/src/events/NotebookEvent.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mattrunyon added a commit that referenced this pull request Mar 30, 2023
@mattrunyon
feat: Double click notebook tab to remove its preview status (#1190)
4870171 
Something I noticed while working on #1189 is that we didn't support
double clicking the tab to promote from preview to normal state like
VSCode does. This PR lets you double click the tab of a notebook in
preview to change it from preview state to normal state.

Tested double clicking preview notebook, non-preview notebook, and
opening other notebooks in preview after promoting via double click
mofojed
mofojed requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right - if I single-click on foo.py, it opens as preview, and then I single-click on bar.py, and it just promotes the existing preview rather than opening bar.py in the preview.

@mattrunyon mattrunyon requested a review from mofojed March 30, 2023 18:56
@mattrunyon
Copy link
Collaborator Author

Good catch. Think it's all fixed now

@mattrunyon mattrunyon merged commit a279670 into deephaven:main Mar 31, 2023
@mattrunyon mattrunyon deleted the file-open-flash branch March 31, 2023 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees

@mattrunyon mattrunyon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double clicking a file causes the loader to flash incorrectly
2 participants
@mattrunyon @mofojed