Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve text labels based on suggestions from chatGPT #1118

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Feb 28, 2023

I asked chatGPT to help me brainstorm improvements to some of the labels and hint text based on the Apple Human Interface Guidelines. I then edited them as human to improve them further.

Review and let me know if you think any are worse or weird.

I asked chatGPT to help me brainstorm improvements to some of the labels and hint text based on the Apple Human Interface Guidelines. I then edited them as human to improve them further.
@dsmmcken dsmmcken self-assigned this Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #1118 (3571ee6) into main (3900a2e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1118   +/-   ##
=======================================
  Coverage   43.37%   43.37%           
=======================================
  Files         434      434           
  Lines       32617    32617           
  Branches     8218     8218           
=======================================
  Hits        14148    14148           
  Misses      18420    18420           
  Partials       49       49           
Flag Coverage Δ
unit 43.37% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...udio/src/settings/ColumnSpecificSectionContent.tsx 98.73% <ø> (ø)
...e-studio/src/settings/FormattingSectionContent.tsx 63.11% <ø> (ø)
packages/code-studio/src/settings/SettingsMenu.tsx 11.11% <ø> (ø)
...de-studio/src/settings/ShortcutsSectionContent.tsx 5.00% <ø> (ø)
packages/iris-grid/src/IrisGrid.tsx 27.36% <ø> (ø)
...ges/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx 8.33% <0.00%> (ø)
packages/iris-grid/src/sidebar/RollupRows.tsx 2.80% <ø> (ø)
...es/iris-grid/src/sidebar/SelectDistinctBuilder.tsx 4.08% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Co-authored-by: Mike Bender <mikebender@deephaven.io>
@mofojed mofojed self-requested a review February 28, 2023 22:27
@dsmmcken dsmmcken merged commit d852e49 into main Mar 1, 2023
@dsmmcken dsmmcken deleted the dmckenzie_chatgpt_labels branch March 1, 2023 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants