Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Disable applying "No formatting" #1107

Merged
merged 1 commit into from
Feb 27, 2023
Merged

fix: Disable applying "No formatting" #1107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions packages/iris-grid/src/sidebar/conditional-formatting/ColumnFormatEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
getConditionConfig,
getDefaultStyleConfig,
ModelColumn,
FormatStyleType,
} from './ConditionalFormattingUtils';
import ConditionEditor from './ConditionEditor';
import StyleEditor from './StyleEditor';
Expand Down Expand Up @@ -83,14 +84,20 @@ function ColumnFormatEditor(props: ColumnFormatEditorProps): JSX.Element {

useEffect(
function updateColumnFormat() {
let isValid = conditionValid;

if (selectedColumn === undefined) {
log.debug('Column is not selected, skip update.');
return;
log.debug('Column is not selected, invalidating update.');
isValid = false;
}
if (selectedStyle === undefined) {
log.debug('Style is not selected, skip update.');
return;
if (
selectedStyle === undefined ||
selectedStyle.type === FormatStyleType.NO_FORMATTING
) {
log.debug('Style is not selected, invalidating update.');
isValid = false;
}

const { type, name } = selectedColumn;
const column = { type, name };
onChange(
Expand All @@ -99,7 +106,7 @@ function ColumnFormatEditor(props: ColumnFormatEditorProps): JSX.Element {
style: selectedStyle,
...conditionConfig,
},
conditionValid
isValid
);
},
[onChange, selectedColumn, selectedStyle, conditionConfig, conditionValid]
Expand Down