Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix VITE_CORE_API_URL in README.md #1102

Merged
merged 5 commits into from
Mar 6, 2023

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Feb 23, 2023

No description provided.

@vbabich vbabich self-assigned this Feb 23, 2023
@dsmmcken
Copy link
Contributor

Should this section even be there? Doesn't the default .env.development already set this up correctly?

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1102 (eb5e9fc) into main (e4cb461) will increase coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
+ Coverage   42.91%   43.38%   +0.47%     
==========================================
  Files         434      435       +1     
  Lines       32593    32692      +99     
  Branches     8198     8243      +45     
==========================================
+ Hits        13987    14185     +198     
+ Misses      18557    18458      -99     
  Partials       49       49              
Flag Coverage Δ
unit 43.38% <ø> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/iris-grid/src/GotoRow.tsx 31.25% <0.00%> (-6.25%) ⬇️
packages/iris-grid/src/IrisGrid.tsx 27.01% <0.00%> (-0.35%) ⬇️
...sidebar/conditional-formatting/ConditionEditor.tsx 8.00% <0.00%> (-0.28%) ⬇️
...ebar/conditional-formatting/ColumnFormatEditor.tsx 3.70% <0.00%> (-0.22%) ⬇️
packages/jsapi-utils/src/TableUtils.ts 53.43% <0.00%> (-0.02%) ⬇️
packages/code-studio/src/AppRoot.tsx 0.00% <0.00%> (ø)
packages/code-studio/src/styleguide/index.tsx 0.00% <0.00%> (ø)
...ackages/code-studio/src/remote-component.config.js 100.00% <0.00%> (ø)
...udio/src/settings/ColumnSpecificSectionContent.tsx 98.73% <0.00%> (ø)
...ages/code-studio/src/styleguide/StyleGuideRoot.tsx 0.00% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bmingles
Copy link
Contributor

Should this section even be there? Doesn't the default .env.development already set this up correctly?

It does look like the combination of .env + .env.development files handle these 2 env vars. I deleted the .env.local files and was able to run things.

@vbabich
Copy link
Collaborator Author

vbabich commented Feb 23, 2023

Should this section even be there? Doesn't the default .env.development already set this up correctly?

Might still need this for custom setups. Should I prepend it with something like

If your DHC address is different from the default `http://localhost:10000`, edit `.env.local` in each package to contain...

?

@dsmmcken
Copy link
Contributor

Yes that's better.

README.md Outdated Show resolved Hide resolved
@vbabich vbabich requested a review from mattrunyon March 6, 2023 15:43
README.md Outdated Show resolved Hide resolved
@vbabich vbabich requested a review from mattrunyon March 6, 2023 20:29
@vbabich vbabich merged commit 57af185 into deephaven:main Mar 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants