Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update versions of some dependencies with vulnerabilities #1079

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Feb 9, 2023

  • The only vulnerability left is in jszip, which we still have pinned

@mofojed mofojed self-assigned this Feb 9, 2023
Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix test failure

Should there be any corresponding package.json updates to this? I see plotly was set to 2.18.1, but wasn't sure if that was what fixed the audit or if it was the dependencies of plotly that needed to be bumped

- The only vulnerability left is in jszip, which we still have pinned...
- Needed to update transformIgnorePatterns
- Updated plotly version and types
- Updated to use correct Ohlc name (it was renamed in types)
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #1079 (33ddbb5) into main (3900a2e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1079   +/-   ##
=======================================
  Coverage   43.37%   43.37%           
=======================================
  Files         434      434           
  Lines       32617    32617           
  Branches     8218     8218           
=======================================
  Hits        14148    14148           
  Misses      18420    18420           
  Partials       49       49           
Flag Coverage Δ
unit 43.37% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/chart/src/ChartUtils.ts 64.23% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mofojed mofojed enabled auto-merge (squash) February 28, 2023 22:28
@mofojed mofojed merged commit 4ed5787 into deephaven:main Feb 28, 2023
@mofojed mofojed deleted the feb9-audit-fix branch February 28, 2023 22:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants