feat: jsapi core module #1075
Closed
feat: jsapi core module #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Feb 8, 2023
mofojed
commented
- Just showing that we can import the JS API as a module dynamically
- Needs Update DeepHavenJsApiLinker to allow exporting GWT JsTypes as ES6 module deephaven-core#2733
Some of them were using global dh instead of the imported dh
- Incomplete, but with this way we should be able to mock the JS API in actual TS instead of the garbage we're doing now
- Remove unnecessary comments and logging
Needed to add vite/client typings
- Needed for top-level await
|
Opening up #1084 instead |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.