Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use code-splitting on routes #444

Open
mofojed opened this issue Feb 18, 2022 · 0 comments
Open

Use code-splitting on routes #444

mofojed opened this issue Feb 18, 2022 · 0 comments
Assignees
@mofojed
Labels
enhancement New feature or request
Milestone
Backlog

Comments

@mofojed
Copy link
Member

mofojed commented Feb 18, 2022

Instead of having a separate package for embed-grid, I believe it would be possible to have it within the same package, by just using code-splitting on routes. Try that out, make sure it works in deephaven-core, and see if we can't remove the embed-grid package entirely.
@mofojed mofojed added enhancement New feature or request triage Issue requires triage and removed triage Issue requires triage labels Feb 18, 2022
@mofojed mofojed added this to the March 2022 milestone Feb 23, 2022
@mofojed mofojed self-assigned this Feb 23, 2022
@mofojed mofojed modified the milestones: March 2022, April 2022 Apr 5, 2022
@mofojed mofojed modified the milestones: April 2022, May 2022 May 2, 2022
@vbabich vbabich modified the milestones: May 2022, June 2022 Jun 1, 2022
@mofojed mofojed modified the milestones: June 2022, July 2022 Jul 5, 2022
@mofojed mofojed modified the milestones: July 2022, August 2022 Jul 25, 2022
@mofojed mofojed modified the milestones: August 2022, September 2022 Sep 9, 2022
@mofojed mofojed modified the milestones: September 2022, October 2022 Oct 3, 2022
@mofojed mofojed mentioned this issue Feb 10, 2023
Merged
mofojed added a commit that referenced this issue Feb 12, 2023
@mofojed
feat: Import JS API as a module (#1084)
9aab657 
- Pulled the types out of `jsapi-shim` into a separate pacakge
`jsapi-types`
- Now other packages can import just the types without the shim possibly
failing because the API isn't loaded yet
- Will be deprecated/replaced with the automatically published TS
definitions when @niloc132 has finished that
- Added `jsapi-bootstrap` package to load the API and display an error
if it can't load
  - Can set the API globally, or use it from a React context object
  - Displays an error if the API cannot be loaded
- Use code-splitting to bootstrap the API globally to keep existing code
running until we port everything over
- We should now look at completing #444 , and get rid of the
`embed-grid` and `embed-chart` packages. We can now code-split at the
top level.
- Enabled proxy in both embed-grid and embed-chart, keeping the loading
similar between all three apps
- Requires change deephaven/deephaven-core#2733

Breaking Change: The JS API packaged as a module is now required for the
`code-studio`, `embed-grid`, and `embed-chart` applications. Existing
(Enterprise) applications should be able to use `jsapi-shim` still and
load the JS API using the old method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mofojed mofojed

Labels
enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@vbabich @mofojed