Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid column tooltips don't work when mouse enters from above #412

Closed
niloc132 opened this issue Feb 2, 2022 · 1 comment · Fixed by #419
Closed

Grid column tooltips don't work when mouse enters from above #412

niloc132 opened this issue Feb 2, 2022 · 1 comment · Fixed by #419
Assignees
@dsmmcken
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@niloc132
Copy link
Member

niloc132 commented Feb 2, 2022

Description

A clear and concise description of what the bug is.

Steps to reproduce

  1. Open a table in the web UI
  2. Ensure the new grid panel is in a tab with some content above it - the console, command history, etc
  3. From above, bring the mouse over a table column and pause to wait for the tooltip showing column information

Expected results
Tooltip shows up within a second or so.

Actual results
Nothing happens. User must instead hover first over the table (contents, another column, empty column space, etc).
@niloc132 niloc132 added bug Something isn't working triage Issue requires triage labels Feb 2, 2022
@mofojed mofojed added the good first issue Good for newcomers label Feb 2, 2022
@dsmmcken dsmmcken self-assigned this Feb 2, 2022
@dsmmcken
Copy link
Contributor

dsmmcken commented Feb 2, 2022

It seems to be limited to the case of enter from above, exit upward, then enter from above again.

showColumnTooltip is never removed from state, so it can never be re-shown, bug introduced by the fix for #306.

@mofojed mofojed removed the triage Issue requires triage label Feb 2, 2022
dsmmcken added a commit that referenced this issue Feb 2, 2022
@dsmmcken
Fix irisgrid tooltip state tracking
984e9f1 
- Resolves Grid column tooltips don't work when mouse enters from above #412
- tooltips now have onExited callback, irisgrid updates it's internal state now tooltip exit
- Caused by fix for pr #306, introduced this new edge case
- Remove this.isExiting from popper, doesn't appear to ever have been used
@dsmmcken dsmmcken mentioned this issue Feb 2, 2022
Merged
dsmmcken added a commit that referenced this issue Feb 2, 2022
@dsmmcken
Fix irisgrid tooltip state tracking (#419)
b8f3009 
- Resolves Grid column tooltips don't work when mouse enters from above #412
- tooltips now have onExited callback, irisgrid updates it's internal state now tooltip exit
- Caused by fix for pr #306, introduced this new edge case
- Remove this.isExiting from popper, doesn't appear to ever have been used
@dsmmcken dsmmcken linked a pull request Feb 2, 2022 that will close this issue
Fix irisgrid tooltip state tracking #419
Merged
@dsmmcken dsmmcken closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsmmcken dsmmcken

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix irisgrid tooltip state tracking deephaven/web-client-ui
3 participants
@niloc132 @dsmmcken @mofojed