Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting theme via query string parameter #2203

Closed
bmingles opened this issue Aug 28, 2024 · 0 comments · Fixed by #2204
Closed

Allow setting theme via query string parameter #2203

bmingles opened this issue Aug 28, 2024 · 0 comments · Fixed by #2204
Assignees
@bmingles
Labels
enhancement New feature or request

Comments

@bmingles
Copy link
Contributor

Embed widget doesn't expose the theme selector. It would be nice as a consumer to be able to pass the desired theme key via a query string parameter. This will enable things like the vscode extension to pick a default dh theme that matches the vscode theme (Theme Selection / Configuration #37)
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Aug 28, 2024
@bmingles bmingles self-assigned this Aug 28, 2024
@bmingles bmingles removed the triage Issue requires triage label Aug 28, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Aug 28, 2024
@bmingles
Set selected theme via query string param (deephaven#2203)
d0f2165
bmingles added a commit to bmingles/web-client-ui that referenced this issue Aug 28, 2024
@bmingles
Updated tests (deephaven#2203)
214352d
bmingles added a commit to bmingles/web-client-ui that referenced this issue Aug 28, 2024
@bmingles
Updated test (deephaven#2203)
837e5be
@bmingles bmingles mentioned this issue Aug 28, 2024
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Aug 29, 2024
@bmingles
Split out getDefaultSelectedThemeKey (deephaven#2203)
6dd4af7
bmingles added a commit to bmingles/web-client-ui that referenced this issue Aug 29, 2024
@bmingles
Fixed tests (deephaven#2203)
1dfc531
bmingles added a commit to bmingles/web-client-ui that referenced this issue Aug 29, 2024
@bmingles
Improved test label (deephaven#2203)
bd54dc7
bmingles added a commit to bmingles/web-client-ui that referenced this issue Aug 30, 2024
@bmingles
Renamed query string param (deephaven#2203)
6a020c5
@bmingles bmingles mentioned this issue Sep 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Set selected theme via query string param bmingles/web-client-ui
1 participant
@bmingles