-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@deephaven/utils - errors when installing in vscode extension #2185
Comments
We should move test code such as |
My vote would be a separate package since it's not guaranteed that consumers will use jest at all. |
To clarify my previous comment... files that depend on |
I attempted to install @deephaven/utils in the vscode-deephaven extension and get a number of errors:
It looks like there are at least 2 classes of errors here:
CustomEvent
type (presumably due to differences in TypeScript version or tsconfig target)jest
. This dependency is not declared inpackage.json
. We may also want to remove the dependency onjest
from@deephaven/utils
altogether since not all consumers would be usingjest
as their testing framework.The text was updated successfully, but these errors were encountered: