Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI should differentiate between Partitioned Tables and Partition-Aware Source Tables #2049

Closed
rbasralian opened this issue May 31, 2024 · 5 comments · Fixed by #2110
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rbasralian
Copy link

If I have a PartitionAwareSourceTable, I get the partitioned table viewer in the UI, which is very helpful, but a bit confusing because it tells me I have a "Partitioned Table":

image

It is a partitioned table in the sense that "it is a table, and it has partitions", but it's not an actual io.deephaven.engine.table.PartitionedTable.

It would be helpful if there were some way to see in the UI what the actual table type is (like some small text under "where it says "Partitioned Table" with the class name...or even a tooltip when you hover over "Partitioned Table", or the table's tab).

@rbasralian rbasralian added enhancement New feature or request triage Issue requires triage labels May 31, 2024
@vbabich
Copy link
Collaborator

vbabich commented Jun 4, 2024

@rbasralian Why is it important to know the distinction in the UI? I don't think the UI can get this information at this point.

@vbabich vbabich added the question Further information is requested label Jun 4, 2024
@rbasralian
Copy link
Author

It's not a huge deal but it's confusing. The words "partitioned table" mean something different & pretty specific when you're writing a query. In this case I had a regular table not a PartitionedTable, and I got hung up for a few minutes trying to understand what table operations like .where() would actually return and whether I'd have to call .merge() at some point in the query.

The "Merge" button in the UI makes it even more confusing, because with a PartitionAwareSourceTable like this, you generally don't think of "view all partitions" as a "merge" operation — since it's not actually a merge() but rather a .where() with no arguments.

@vbabich
Copy link
Collaborator

vbabich commented Jun 4, 2024

I think our partitioning UI and underlying data models intentionally make both kinds of tables behave as if they were the same. This is probably fine for basic use cases but might be confusing when the table type is important. I also had this issue once and had to call .getClass() on a table object to get this information.

@vbabich
Copy link
Collaborator

vbabich commented Jun 12, 2024

@rbasralian We could re-label Partitioned table as Partition-aware source table and change the Merge button to something more appropriate. Would the label Coalesce make more sense for partition-aware source tables? Or something else?

@dsmmcken
Copy link
Contributor

See #2079 for details

@vbabich vbabich removed question Further information is requested triage Issue requires triage labels Jun 18, 2024
@vbabich vbabich added this to the June 2024 milestone Jun 18, 2024
@vbabich vbabich modified the milestones: June 2024, July 2024 Jul 9, 2024
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Jul 17, 2024
## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.86.0

### Features

* Add option to disable WebGL rendering
([#2134](deephaven/web-client-ui#2134))
([011eb33](deephaven/web-client-ui@011eb33))
* Core plugins refactor, XComponent framework
([#2150](deephaven/web-client-ui#2150))
([2571fad](deephaven/web-client-ui@2571fad))
* IrisGridTheme iconSize
([#2123](deephaven/web-client-ui#2123))
([58ee88d](deephaven/web-client-ui@58ee88d)),
closes [#885](deephaven/web-client-ui#885)
* Partitioned Table UI Enhancements
([#2110](deephaven/web-client-ui#2110))
([de5ce40](deephaven/web-client-ui@de5ce40)),
closes [#2079](deephaven/web-client-ui#2079)
[#2066](deephaven/web-client-ui#2066)
[#2103](deephaven/web-client-ui#2103)
[#2104](deephaven/web-client-ui#2104)
[#2105](deephaven/web-client-ui#2105)
[#2106](deephaven/web-client-ui#2106)
[#2107](deephaven/web-client-ui#2107)
[#2108](deephaven/web-client-ui#2108)
[#2109](deephaven/web-client-ui#2109)
[#2049](deephaven/web-client-ui#2049)
[#2120](deephaven/web-client-ui#2120)
[#1904](deephaven/web-client-ui#1904)


### Bug Fixes

* error when edited cell is out of grid viewport
([#2148](deephaven/web-client-ui#2148))
([3fccd43](deephaven/web-client-ui@3fccd43)),
closes [#2087](deephaven/web-client-ui#2087)

## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.85.2


### Bug Fixes

* Fix missing scrim background on LoadingOverlay
([#2098](deephaven/web-client-ui#2098))
([c9ed895](deephaven/web-client-ui@c9ed895))

## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.85.1

##
[0.85.1](deephaven/web-client-ui@v0.85.0...v0.85.1)
(2024-07-08)


### Bug Fixes

* re-export remaining types needed by dh ui from @react-types/shared
([#2132](deephaven/web-client-ui#2132))
([2119a61](deephaven/web-client-ui@2119a61))



## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.85.0

### Features

* ComboBox - @deephaven/jsapi-components
([#2077](deephaven/web-client-ui#2077))
([115e057](deephaven/web-client-ui@115e057)),
closes [#2074](deephaven/web-client-ui#2074)


### Bug Fixes

* Allow ComboBox to accept the FocusableRef for ref
([#2121](deephaven/web-client-ui#2121))
([8fe9bad](deephaven/web-client-ui@8fe9bad))
* Ref was not being passed through for Picker
([#2122](deephaven/web-client-ui#2122))
([a11e2ce](deephaven/web-client-ui@a11e2ce))

Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants