Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move UIConstants to @deephaven/components #1973

Closed
bmingles opened this issue Apr 30, 2024 · 1 comment · Fixed by #2133
Closed

Move UIConstants to @deephaven/components #1973

bmingles opened this issue Apr 30, 2024 · 1 comment · Fixed by #2133
Assignees
@bmingles
Labels
enhancement New feature or request
Milestone
July 2024

Comments

@bmingles
Copy link
Contributor

Most of the constants (except for SPELLCHECK_FALSE_ATTRIBUTE) in packages/utils/src/UIConstants.ts could be moved to @deephaven/components.
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Apr 30, 2024
@bmingles bmingles self-assigned this Apr 30, 2024
@bmingles bmingles mentioned this issue Apr 30, 2024
Merged
@vbabich vbabich added this to the May 2024 milestone Apr 30, 2024
@vbabich vbabich removed the triage Issue requires triage label Apr 30, 2024
@mofojed mofojed modified the milestones: May 2024, June 2024 Jun 4, 2024
@mofojed
Copy link
Member

mofojed commented Jul 8, 2024

Please deprecate in @deephaven/utils and add to @deephaven/components. Don't want this to be a breaking change.

bmingles added a commit to bmingles/web-client-ui that referenced this issue Jul 8, 2024
@bmingles
Fixed key warning in unit tests (deephaven#1973)
2aa46f3
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jul 8, 2024
@bmingles
Moved some UI constants and deprecated old ones (deephaven#1973)
1cd054b
@bmingles bmingles mentioned this issue Jul 8, 2024
Merged
@vbabich vbabich modified the milestones: June 2024, July 2024 Jul 9, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jul 9, 2024
@bmingles
Deprecated remaining UIConstants (deephaven#1973)
8a4f598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request
Projects
None yet
Milestone
July 2024
Development

Successfully merging a pull request may close this issue.

refactor: 1973 UI constants bmingles/web-client-ui
3 participants
@bmingles @vbabich @mofojed