Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dashboard tabs when the variable is reassigned or deleted #1971

Closed
mattrunyon opened this issue Apr 29, 2024 · 0 comments · Fixed by #2243
Closed

Replace dashboard tabs when the variable is reassigned or deleted #1971

mattrunyon opened this issue Apr 29, 2024 · 0 comments · Fixed by #2243
Assignees
@mattrunyon
Labels
enhancement New feature or request
Milestone
September 2024

Comments

@mattrunyon
Copy link
Collaborator

When a dashboard is opened with a name of a dashboard that is already open, we should replace the existing dashboard tab like we do with tables. We should also ensure the dashboard is removed if the variable is removed via del variable
@mattrunyon mattrunyon added enhancement New feature or request triage Issue requires triage labels Apr 29, 2024
@vbabich vbabich added this to the May 2024 milestone Apr 30, 2024
@vbabich vbabich removed the triage Issue requires triage label Apr 30, 2024
@mofojed mofojed modified the milestones: May 2024, June 2024 Jun 4, 2024
@vbabich vbabich modified the milestones: June 2024, July 2024 Jul 9, 2024
@mofojed mofojed modified the milestones: July 2024, September 2024 Sep 3, 2024
@mattrunyon mattrunyon mentioned this issue Oct 2, 2024
Merged
mattrunyon added a commit that referenced this issue Oct 2, 2024
@mattrunyon
fix: Reuse dashboard tabs when reassigning the variable (#2243)
d2c6eab 
Fixes #1971

Tested with this code run 1 line at a time

```python
import deephaven.ui as ui

a = ui.dashboard(ui.text("Hello"))

a = ui.dashboard(ui.text("World"))

a = ui.text("Hello")

a = ui.dashboard(ui.text("Hello"))

del a
```

Also tested dashboards still load in embed-widget. There was a race
condition since the `makeUseListenerFunction` hook was using
`useEffect`. This caused the event to emit between the event hub being
set and the listener being added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattrunyon mattrunyon

Labels
enhancement New feature or request
Projects
None yet
Milestone
September 2024
Development

Successfully merging a pull request may close this issue.

fix: Reuse dashboard tabs when reassigning the variable mattrunyon/web-client-ui
3 participants
@vbabich @mofojed @mattrunyon