-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ListView + Picker - Item icon support #1959
feat: ListView + Picker - Item icon support #1959
Conversation
92754fc
to
8aed8db
Compare
2a3a671
to
c02cd50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some docs clean up will help, also question about UIConstants which may warrant a follow up.
} from '@deephaven/components'; | ||
import { vsAccount, vsPerson } from '@deephaven/icons'; | ||
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; | ||
import { LIST_VIEW_ROW_HEIGHTS } from '@deephaven/utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know not part of this change... but why are the UIConstants
in @deephaven/utils
and not @deephaven/components
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this module was created before the UI work really started as part of moving some ACL utils to DHC. Looks like all but SPELLCHECK_FALSE_ATTRIBUTE
could be moved to @deephaven/components
I created #1973 as a follow up
@mofojed I addressed your comments. I also had to fix an issue in the styleguide
|
This example shows both basic and table data sources.
resolves #1890