Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useViewportData - setViewport should maintain last firstRow value when table size changes #1928

Closed
bmingles opened this issue Apr 10, 2024 · 0 comments · Fixed by #2008
Closed

useViewportData - setViewport should maintain last firstRow value when table size changes #1928

bmingles opened this issue Apr 10, 2024 · 0 comments · Fixed by #2008
Assignees
@bmingles
Labels
enhancement New feature or request web-client-ui
Milestone
May 2024

Comments

@bmingles
Copy link
Contributor

bmingles commented Apr 10, 2024 •
edited
Loading

useViewportData currently calls setViewport(0) whenever the associated table size changes. This makes sense for filtered data on tables that don't change very frequently, but it's not the best option for ticking tables. This should be smarter to handle both ticking and filtered scenarios appropriately. (probably makes sense to work on this as part of ComboBox since it would support both filtering and ticking)
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Apr 10, 2024
@bmingles bmingles self-assigned this Apr 10, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 10, 2024
@bmingles
First attempt at useViewportData fix (deephaven#1928)
e1bebc2
@vbabich vbabich added this to the April 2024 milestone Apr 16, 2024
@vbabich vbabich removed the triage Issue requires triage label Apr 16, 2024
@mofojed mofojed modified the milestones: April 2024, May 2024 May 13, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 13, 2024
@bmingles
First attempt at useViewportData fix (deephaven#1928)
28a9b2f
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 13, 2024
@bmingles
Memoized callback in useTableSize (deephaven#1928)
6595850
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 13, 2024
@bmingles
Memoize onTableUpdated (deephaven#1928)
efe68dc
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 13, 2024
@bmingles
Removed chatty log (deephaven#1928)
90df38d
@bmingles bmingles mentioned this issue May 13, 2024
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 13, 2024
@bmingles
Comment (deephaven#1928)
8033056
@mofojed mofojed mentioned this issue May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request web-client-ui
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

fix: useViewportData - memoize subscriptions and first row of viewport bmingles/web-client-ui
3 participants
@bmingles @vbabich @mofojed