feat: Picker - formatter settings #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1907 +/- ##
==========================================
+ Coverage 46.23% 46.26% +0.02%
==========================================
Files 645 646 +1
Lines 38241 38252 +11
Branches 9672 9673 +1
==========================================
+ Hits 17682 17697 +15
+ Misses 20506 20502 -4
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmingles
force-pushed
the
1889-picker-column-types2
branch
from
8bff576
to
c032c9b
Compare
mofojed
reviewed
Apr 3, 2024
mofojed
previously approved these changes
Apr 3, 2024
| @@ -38,7 +38,7 @@ export function useGetItemIndexByValue<TValue>({ | |||
| return index === -1 ? null : index; | |||
| } catch (err) { | |||
| log.debug('Error seeking row', { column, value, columnValueType }); | |||
| return null; | |||
| throw err; | |||
There was a problem hiding this comment.
I wouldn't bother logging it either - consumer either catches it and logs it or does something with it in which case the log would be extra spam. If it's uncaught would be logged as an uncaught promise anyway.
mofojed
approved these changes
Apr 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindAllMethodsfunction. It now excludes gettersresolves #1889