Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestUtils - Generate exhaustive boolean combinations #1809

Closed
bmingles opened this issue Feb 15, 2024 · 0 comments · Fixed by #1811
Closed

TestUtils - Generate exhaustive boolean combinations #1809

bmingles opened this issue Feb 15, 2024 · 0 comments · Fixed by #1811
Assignees
@bmingles
Labels
enhancement New feature or request

Comments

@bmingles
Copy link
Contributor

Some unit tests benefit from running a matrix of possible boolean values for n possible arguments. Generating these by hand can be a bit tedious and slightly error prone. We should create a helper utility that can do this automatically.
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Feb 15, 2024
@bmingles bmingles self-assigned this Feb 15, 2024
@bmingles bmingles removed the triage Issue requires triage label Feb 15, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Feb 15, 2024
@bmingles
generateBooleanCombinations (deephaven#1809)
d61d350
bmingles added a commit to bmingles/web-client-ui that referenced this issue Feb 15, 2024
@bmingles
Added spread support to MockProxy (deephaven#1809)
bf1ed5c
bmingles added a commit to bmingles/web-client-ui that referenced this issue Feb 15, 2024
@bmingles
Fixed console error in test (deephaven#1809)
acf544a
@bmingles bmingles mentioned this issue Feb 15, 2024
Merged
bmingles added a commit that referenced this issue Feb 16, 2024
@bmingles
feat: Test Utils - Generate exhaustive boolean combinations and MockP…
0a2f054 
…roxy spread (#1811)

New test util features
- Generate exhaustive boolean combinations
- Fixed some type errors in `usePickerWithSelectedValues.test.ts` (also
updated it to use the new boolean test util)
- Added spread support to MockProxy to avoid empty objects when making
copies
- Fixed a console error that was happening due to `null` icons passed to
FontAwesomeIcon component in tests

resolves #1809
@mofojed mofojed mentioned this issue Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@bmingles